bpo-22674: fix test_strsignal on OSX#6085
Merged
Merged
Conversation
pitrou
reviewed
Mar 12, 2018
Member
There was a problem hiding this comment.
Since this could fail on other systems, I'd like the signal.strsignal result to be showed on failure. You can use the second argument of assertTrue for that.
Member
|
Thanks. Hopefully a macOS user can come by and check this works... |
ned-deily
approved these changes
Mar 12, 2018
ned-deily
left a comment
ned-deily
left a comment
Member
There was a problem hiding this comment.
Test no longer fails on macOS. Thanks!
seirl
force-pushed
the
fix_test_strsignal
branch
from
March 12, 2018 18:48
9fd4e0a to
65822fd
Compare
Contributor
Author
|
I used assertIn instead of assertTrue, it's a lot more explicit like that. |
Member
|
Thanks @seirl. @ned-deily, I expect that the test modification doesn't break macOS, as the new test is more lenient. Will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed the behavior to remove OSX specific handling and forgot to update the tests. This should fix it, but I don't have an OSX machine so I can't test it myself... If the CI is still down for OSX, I'll need someone else to test it first :/
https://bugs.python.org/issue22674