bpo-32970: Improve disassembly of the MAKE_FUNCTION instruction.#5937
Merged
serhiy-storchaka merged 1 commit intoMar 11, 2018
Merged
Conversation
ncoghlan
reviewed
Mar 1, 2018
ncoghlan
left a comment
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
The MAKE_FUNCTION change looks good to me, but the FORMAT_VALUE changes seem unrelated.
| argval = ((None, str, repr, ascii)[arg & 0x3], bool(arg & 0x4)) | ||
| argrepr = ('', 'str', 'repr', 'ascii')[arg & 0x3] | ||
| argval, argrepr = FORMAT_VALUE_CONVERTERS[arg & 0x3] | ||
| argval = (argval, bool(arg & 0x4)) |
Contributor
There was a problem hiding this comment.
This seems like an unrelated refactoring?
Member
Author
There was a problem hiding this comment.
Initially I implemented the logic for MAKE_FUNCTION as a sequence of ifs. But later I seen that it can be implemented using a single constant. Since I added the MAKE_FUNCTION_FLAGS global I take the chance to move constants for FORMAT_VALUE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32970