Skip to content

bpo-32257: Add ssl.OP_NO_RENEGOTIATION#5904

Merged
ned-deily merged 1 commit into
python:masterfrom
tiran:bpo-32257-no-renego
May 15, 2018
Merged

bpo-32257: Add ssl.OP_NO_RENEGOTIATION#5904
ned-deily merged 1 commit into
python:masterfrom
tiran:bpo-32257-no-renego

Conversation

@tiran

@tiran tiran commented Feb 26, 2018

Copy link
Copy Markdown
Member

The ssl module now contains OP_NO_RENEGOTIATION constant, available with
OpenSSL 1.1.0h or 1.1.1.

Note, OpenSSL 1.1.0h hasn't been released yet.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32257

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR description says 1.1.0h, but this says 1.1.0n. Which is it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, it's a typo. Fixed

@tiran
tiran force-pushed the bpo-32257-no-renego branch 2 times, most recently from 8eb3007 to b120eef Compare February 27, 2018 08:24
@ned-deily

Copy link
Copy Markdown
Member

@tiran, What's the status of this PR?

@tiran

tiran commented May 14, 2018

Copy link
Copy Markdown
Member Author

@ned-deily It's too late to get it into 3.7. I'll just merge it into 3.8.

The ssl module now contains OP_NO_RENEGOTIATION constant, available with
OpenSSL 1.1.0h or 1.1.1.

Note, OpenSSL 1.1.0h hasn't been released yet.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran

tiran commented May 14, 2018

Copy link
Copy Markdown
Member Author

@ned-deily permitted me to merge the PR to 3.7.

@ned-deily
ned-deily merged commit 67c4801 into python:master May 15, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2018
The ssl module now contains OP_NO_RENEGOTIATION constant, available with
OpenSSL 1.1.0h or 1.1.1.

Note, OpenSSL 1.1.0h hasn't been released yet.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 67c4801)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-6877 is a backport of this pull request to the 3.7 branch.

tiran added a commit that referenced this pull request May 16, 2018
The ssl module now contains OP_NO_RENEGOTIATION constant, available with
OpenSSL 1.1.0h or 1.1.1.

Note, OpenSSL 1.1.0h hasn't been released yet.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 67c4801)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants