Fix some warnings produced by different compilers.#5593
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Feb 9, 2018
Merged
Fix some warnings produced by different compilers.#5593serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
serhiy-storchaka
added
type-bug
Member
Author
|
@skrah, please take a look. This PR touches libmpdec, fixes warnings on PPC64 AIX (http://buildbot.python.org/all/#/builders/10/builds/662). |
Contributor
|
This -Wimplicit-fallthrough warning is the most annoying warning I've ever encountered. First it depends on the preprocessor and now it gives different results based on the platform (on Linux with gcc-7.2 I get no warning). I'm fine with the patch, but I'll probably add a configure detection at some point and squash the warning with -Wno-implicit-fallthrough. |
|
@serhiy-storchaka: Please replace |
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 9, 2018
(cherry picked from commit bfe4fd5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-5600 is a backport of this pull request to the 3.7 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all warnings are fixed, only the most trivial.