Skip to content

bpo-32394: Remove some TCP options on old version Windows. #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

bpo-32394: Remove some TCP options on old version Windows. #5468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Lib/socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,28 @@
"""

import _socket
from _socket import *

import os, sys, io, selectors
from enum import IntEnum, IntFlag

# Remove some options on old version Windows.
# https://msdn.microsoft.com/en-us/library/windows/desktop/ms738596.aspx
if hasattr(sys, 'getwindowsversion'):
_WIN_MAJOR, _, _WIN_BUILD, *_ = sys.getwindowsversion()
if _WIN_MAJOR == 10:
if _WIN_BUILD >= 15063: # Windows 10 1703
pass
elif _WIN_BUILD >= 14393: # Windows 10 1607
del _socket.TCP_KEEPCNT
else:
del _socket.TCP_KEEPCNT
del _socket.TCP_FASTOPEN
elif _WIN_MAJOR < 10:
del _socket.TCP_KEEPCNT
del _socket.TCP_FASTOPEN

from _socket import *

try:
import errno
except ImportError:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-02-01-16-50-00.bpo-32394.fxr_Kc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
socket: Remove TCP_KEEPCNT, TCP_FASTOPEN options on old version Windows.