Skip to content

bpo-32680 add default "sock" on SMTP objects#5345

Merged
giampaolo merged 1 commit into
python:masterfrom
romuald:smtplib-init-sock
Oct 9, 2018
Merged

bpo-32680 add default "sock" on SMTP objects#5345
giampaolo merged 1 commit into
python:masterfrom
romuald:smtplib-init-sock

Conversation

@romuald

@romuald romuald commented Jan 26, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

By default the smtplib.SMTP objects did not have a sock attribute, it
was only created during connect()

https://bugs.python.org/issue32680

@romuald
romuald requested a review from a team as a code owner January 26, 2018 15:31
giampaolo
giampaolo approved these changes Jan 26, 2018
View reviewed changes

@giampaolo giampaolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bitdancer
bitdancer requested changes Jan 26, 2018
View reviewed changes

@bitdancer bitdancer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks correct to me as well, but we need a test and a NEWS entry in the PR.

@bedevere-bot

bedevere-bot commented Jan 26, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@romuald
bpo-32680 add default "sock" on SMTP objects
9517a76 
By default the smtplib.SMTP objects did not have a sock attribute, it
was only created during connect()
@romuald
romuald force-pushed the smtplib-init-sock branch from ba97bdf to 9517a76 Compare October 9, 2018 12:26
@romuald

romuald commented Oct 9, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Oct 9, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@bitdancer, @giampaolo: please review the changes made to this pull request.

@giampaolo
giampaolo merged commit 7b31397 into python:master Oct 9, 2018
@bedevere-bot

bedevere-bot commented Oct 9, 2018

Copy link
Copy Markdown

@giampaolo: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer requested changes
@giampaolo giampaolo giampaolo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@romuald @bedevere-bot @bitdancer @giampaolo @the-knights-who-say-ni