Skip to content

bpo-32529: Replace read with readinto in shutil.copyfileobj#5147

Closed
YoSTEALTH wants to merge 2 commits into
python:masterfrom
YoSTEALTH:master
Closed

bpo-32529: Replace read with readinto in shutil.copyfileobj#5147
YoSTEALTH wants to merge 2 commits into
python:masterfrom
YoSTEALTH:master

Conversation

@YoSTEALTH

@YoSTEALTH YoSTEALTH commented Jan 10, 2018

Copy link
Copy Markdown
Contributor

improved "copyfileobj" function to use less memory

https://bugs.python.org/issue32529

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@YoSTEALTH YoSTEALTH changed the title Update shutil.py 32529 Update shutil.py Jan 10, 2018
@YoSTEALTH YoSTEALTH changed the title 32529 Update shutil.py bpo-32529: Update shutil.py Jan 10, 2018
@asvetlov asvetlov changed the title bpo-32529: Update shutil.py bpo-32529: Replace read with readinto in shutil.copyfileobj Jan 11, 2018
@asvetlov

Copy link
Copy Markdown
Contributor

Please add NEWS entry

@YoSTEALTH

Copy link
Copy Markdown
Contributor Author

@asvetlov i am new to github where exactly do you add this "NEWS entry" ?

@asvetlov

Copy link
Copy Markdown
Contributor

@YoSTEALTH

Copy link
Copy Markdown
Contributor Author

Looks like i created a new pull request, closing this one.

@YoSTEALTH YoSTEALTH closed this Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants