Skip to content

Update shutil.py#5146

Closed
YoSTEALTH wants to merge 1 commit into
python:3.6from
YoSTEALTH:patch-1
Closed

Update shutil.py#5146
YoSTEALTH wants to merge 1 commit into
python:3.6from
YoSTEALTH:patch-1

Conversation

@YoSTEALTH

Copy link
Copy Markdown
Contributor

improved "copyfileobj" function to use less memory

improved copyfileobj to use less memory
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@zware
zware changed the base branch from master to 3.6 January 10, 2018 20:36
@skrah

skrah commented Jan 10, 2018

Copy link
Copy Markdown
Contributor

I know GitHub is not very user friendly, but you can view your pull requests before opening them.

@skrah

skrah commented Jan 10, 2018

Copy link
Copy Markdown
Contributor

Ah, apparently @zware did the right magic now. Reopening.

@zware

zware commented Jan 10, 2018

Copy link
Copy Markdown
Member

It looks like you made this change against the 3.6 branch, so I changed the base branch. However, our workflow is to patch master first, then backport to any other applicable branches. Could you please recreate your pull request as a single commit against the master branch?

@zware
zware removed the request for review from a team January 10, 2018 20:51
@YoSTEALTH

Copy link
Copy Markdown
Contributor Author

@zware I am new to github, i will try and see if i can do what you recommend.

@bitdancer

Copy link
Copy Markdown
Member

You also need to open an issue at bugs.python.org (follow the bedevere/issue-number details link for more).

@YoSTEALTH YoSTEALTH closed this Jan 10, 2018
@YoSTEALTH
YoSTEALTH deleted the patch-1 branch January 10, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants