Skip to content

bpo-28230: Document the pathlib support in tarfile and add tests.#512

Merged
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:bpo-28230-tarfile-pathlib
Mar 8, 2017
Merged

bpo-28230: Document the pathlib support in tarfile and add tests.#512
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:bpo-28230-tarfile-pathlib

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Mar 6, 2017

No description provided.

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir type-feature A feature request or enhancement needs backport to 3.6 tests Tests in the Lib/test dir labels Mar 6, 2017
berkerpeksag
berkerpeksag approved these changes Mar 8, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good to me, thanks! All documented members are correctly tested and tests are passed in my local environment too.

You may want to document this in Misc/NEWS. Side note: We probably should tweak the 3.6 whatsnew document to give readers up-to-date information about pathlib support in the standard library.

I just left a super minor comment.

Lib/test/test_tarfile.py Outdated
tarname = pathlib.Path(self.tarname)
with tarfile.open(tarname, mode=self.mode) as tar:
self.assertIsInstance(tar.name, str)
self.assertEqual(tar.name, os.path.abspath(str(tarname)))
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps use os.fspath instead of str?

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented Mar 8, 2017

I have not added an entry in Misc/NEWS because this change doesn't change the behavior. It just documents existing feature. I'm not sure about What's New document. Path-like support in tarfile (as well as in many other stdlib and third-party modules) is just a side effect of implementing PEP 519 in os and os.path.

@serhiy-storchaka serhiy-storchaka merged commit c45cd16 into python:master Mar 8, 2017
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 8, 2017
@serhiy-storchaka
bpo-28230: Document the pathlib support in tarfile and add tests. (py…
d81e614 
…thon#512)

(cherry picked from commit c45cd16)
@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Mar 9, 2017

I removed the needs backport to 3.6 label since it was done.

@serhiy-storchaka serhiy-storchaka deleted the bpo-28230-tarfile-pathlib branch March 30, 2017 18:48
ilevkivskyi pushed a commit to ilevkivskyi/cpython that referenced this pull request Jan 14, 2018
Add some whitespace; pospone proper solution for typing/python#512
73b7b0b
simpkins added a commit to simpkins/typeshed that referenced this pull request May 12, 2022
@simpkins
tarfile.gettarinfo() accepts PathLike objects
165abd6 
This method has accepted PathLike objects since Python 3.6
(python/cpython#512)
@simpkins simpkins mentioned this pull request May 12, 2022
Merged
JelleZijlstra pushed a commit to python/typeshed that referenced this pull request May 12, 2022
@simpkins
tarfile.gettarinfo() accepts PathLike objects (#7832)
40d6592 
This method has accepted PathLike objects since Python 3.6
(python/cpython#512)
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot @Mariatta
Bump pytest-asyncio from 0.16.0 to 0.17.2 (#512)
9f0fb56 
Bumps [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) from 0.16.0 to 0.17.2.
- [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases)
- [Commits](pytest-dev/pytest-asyncio@v0.16.0...v0.17.2)

---
updated-dependencies:
- dependency-name: pytest-asyncio
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir tests Tests in the Lib/test dir type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @Mariatta @berkerpeksag @the-knights-who-say-ni