bpo-15954: Check return code of wcsxfrm().#508
Merged
serhiy-storchaka merged 2 commits intopython:masterfrom Mar 6, 2017
Merged
bpo-15954: Check return code of wcsxfrm().#508serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka merged 2 commits intopython:masterfrom
Conversation
vstinner
approved these changes
Mar 6, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM except of a minor request.
| } | ||
| } | ||
| result = PyUnicode_FromWideChar(buf, n2); | ||
| exit: |
Member
There was a problem hiding this comment.
While you modify this function, can you please remove useless "if (buf)" and "if (s)" below? PyMem_Free(NULL) is well defined: it does nothing.
Member
Author
There was a problem hiding this comment.
Except adding an overhead for function call.
But I don't think it matters in comparison with the time of calling other functions.
Member
|
Except adding an overhead for function call.
I expect C calls to be *very cheap*. (In Python, function calls are
very expensive, it's the opposite ;-))
|
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.5.1 to 1.5.2. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.5.1...1.5.2) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.