bpo-32327: Fix check for run_in_executor on closed loop#4996
Merged
Conversation
bedevere-bot
added
awaiting merge
and removed
awaiting change review
awaiting changes
labels
1st1
reviewed
Dec 23, 2017
| # but run_until_complete cannot be called on closed loop. | ||
| # Thus iterate once explicitly. | ||
| with self.assertRaises(RuntimeError): | ||
| it = self.loop.run_in_executor(None, func).__await__() |
Member
There was a problem hiding this comment.
Alternatively
coro = self.loop.run_in_executor(None, func)
self.loop.run_until_complete(coro)
coro.close()
Contributor
Author
There was a problem hiding this comment.
self.loop is closed, self.loop.run_until_complete() raises an exception before run_in_executor executing.
1st1
approved these changes
Dec 23, 2017
Member
|
I see. Update: let's keep the tests, I didn't notice that there's was a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop "run_in_executor was never awaited" message on tests run
https://bugs.python.org/issue32327