Skip to content

bpo-29620: iterate over a copy of sys.modules#4800

Merged
akuchling merged 2 commits into
python:masterfrom
kernc:patch-1
Jun 11, 2020
Merged

bpo-29620: iterate over a copy of sys.modules#4800
akuchling merged 2 commits into
python:masterfrom
kernc:patch-1

Conversation

@kernc

@kernc kernc commented Dec 11, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes https://bugs.python.org/issue29620 by wrapping sys.modules.values() into a tuple before iteration.

https://bugs.python.org/issue29620

serhiy-storchaka
serhiy-storchaka reviewed Aug 21, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test? It is enough to create a types.ModuleType subclass with the __warningregistry__ property (or the __getattr__() method) which mutates sys.modules and add its instance to sys.modules.

Add also a news entry (see https://devguide.python.org/committing/#what-s-new-and-news-entries).

Comment thread Lib/unittest/case.py Outdated
@kernc

kernc commented Aug 21, 2018

Copy link
Copy Markdown
Contributor Author

Done. Hope it's ok.

serhiy-storchaka
serhiy-storchaka reviewed Aug 21, 2018
View reviewed changes
Comment thread Lib/unittest/test/test_case.py Outdated
Comment thread Lib/unittest/test/test_case.py Outdated
Comment thread Misc/NEWS.d/next/Library/2018-08-21-16-20-33.bpo-29620.xxx666.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2018-08-21-16-20-33.bpo-29620.xxx666.rst Outdated
@kernc

kernc commented Aug 22, 2018

Copy link
Copy Markdown
Contributor Author

Updated. Thanks.

@kernc

kernc commented Sep 17, 2018

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Do you find any other issues?

@csabella
csabella requested review from serhiy-storchaka and removed request for serhiy-storchaka June 5, 2019 01:01
@krzentner krzentner mentioned this pull request Oct 23, 2019
Merged
@lettergram

lettergram commented Oct 24, 2019

Copy link
Copy Markdown

@kernc I'm running into this issue - is it at all possible to prioritize this issue?

@lettergram

lettergram commented Oct 28, 2019

Copy link
Copy Markdown

@serhiy-storchaka Would it be possible to review this PR or is there something I can do?

@kernc kernc changed the title bpo-29620: iterate over a tuple of sys.modules bpo-29620: iterate over a list of sys.modules Oct 29, 2019
@kernc kernc changed the title bpo-29620: iterate over a list of sys.modules bpo-29620: iterate over a copy of sys.modules Oct 29, 2019
@lettergram

lettergram commented Nov 6, 2019

Copy link
Copy Markdown

@serhiy-storchaka If there's any way either myself or @kernc could help, please let me know!

If there's someone else / something else we need to do please let us know.

@bact bact mentioned this pull request Nov 15, 2019
Merged
@pelillian

pelillian commented Nov 25, 2019

Copy link
Copy Markdown

@serhiy-storchaka Any chance you could take a look at this?

@lettergram

lettergram commented Dec 3, 2019

Copy link
Copy Markdown

@serhiy-storchaka is there anything else required for review?

@csabella
csabella requested review from serhiy-storchaka and removed request for serhiy-storchaka January 17, 2020 12:15
akuchling
akuchling reviewed Mar 5, 2020
View reviewed changes
Comment thread Lib/unittest/test/test_case.py Outdated
@lettergram

lettergram commented Mar 9, 2020

Copy link
Copy Markdown

@akuchling Looks like this is good?

@akuchling akuchling self-assigned this Mar 20, 2020
@csabella

csabella commented May 23, 2020

Copy link
Copy Markdown
Contributor

@akuchling, should this be merged? Thanks!

@akuchling
akuchling merged commit 46398fb into python:master Jun 11, 2020
@miss-islington

miss-islington commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

Thanks @kernc for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented Jun 11, 2020

Copy link
Copy Markdown

GH-20816 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2020
@kernc @miss-islington
bpo-29620: iterate over a copy of sys.modules (pythonGH-4800)
082daf4 
unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2020
@kernc @miss-islington
bpo-29620: iterate over a copy of sys.modules (pythonGH-4800)
12c2321 
unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
@bedevere-bot

bedevere-bot commented Jun 11, 2020

Copy link
Copy Markdown

GH-20817 is a backport of this pull request to the 3.7 branch.

akuchling pushed a commit that referenced this pull request Jun 11, 2020
@miss-islington @kernc
bpo-29620: iterate over a copy of sys.modules (GH-4800) (GH-20816)
3e499cd 
unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
akuchling pushed a commit that referenced this pull request Jun 11, 2020
@miss-islington @kernc
bpo-29620: iterate over a copy of sys.modules (GH-4800) (GH-20817)
f881c86 
unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
@miss-islington

miss-islington commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

Thanks @kernc for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 18, 2021

Copy link
Copy Markdown

GH-29605 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2021
@kernc @miss-islington
bpo-29620: iterate over a copy of sys.modules (pythonGH-4800)
e78fdee 
unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
ambv pushed a commit that referenced this pull request Nov 18, 2021
@miss-islington @kernc
bpo-29620: iterate over a copy of sys.modules (GH-4800) (GH-29605)
71d842b 
unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
1 more reviewer
@akuchling akuchling akuchling approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@akuchling akuchling

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@kernc @lettergram @pelillian @csabella @miss-islington @bedevere-bot @akuchling @serhiy-storchaka @the-knights-who-say-ni @sweeneyde