Skip to content

bpo-32257: [SSL] Support Disabling Renegotiation#4763

Closed
ex172000 wants to merge 3 commits into
python:2.7from
ex172000:fix-issue-32257
Closed

bpo-32257: [SSL] Support Disabling Renegotiation#4763
ex172000 wants to merge 3 commits into
python:2.7from
ex172000:fix-issue-32257

Conversation

@ex172000

@ex172000 ex172000 commented Dec 9, 2017

Copy link
Copy Markdown

Adding a new method in SSLContext so that we can disable
renegotiation easier. This resolves CVE-2009-3555 and
attack demonstrated by thc-ssl-dos.

https://bugs.python.org/issue32257

Adding a new method in SSLContext so that we can disable
renegotiation easier. This resolves CVE-2009-3555 and
attack demonstrated by thc-ssl-dos
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@tiran

tiran commented Dec 9, 2017

Copy link
Copy Markdown
Member

PR is probably not required. OpenSSL performs secure renegotiation by default

https://www.openssl.org/docs/manmaster/man3/SSL_CTX_set_options.html

OpenSSL always attempts to use secure renegotiation as described in RFC5746. This counters the prefix attack described in CVE-2009-3555 and elsewhere.

Adding a new method in SSLContext so that we can disable
renegotiation easier. This resolves CVE-2009-3555 and
attack demonstrated by thc-ssl-dos
Disable SSL3 renegotiation to fix THC-SSL-DOS
Issue.
@csabella

Copy link
Copy Markdown
Contributor

Closing this PR as the underlying ticket has been marked as resolved and closed.

@csabella csabella closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants