Closed
Conversation
CuriousLearner
approved these changes
Nov 18, 2018
Member
CuriousLearner
left a comment
CuriousLearner
left a comment
There was a problem hiding this comment.
This looks good to me. Aslo, I see there were various wording changes in previous PR, which I'm not very sure about.
But at the moment, this looks a good enough change that will align with docs with the docstring and functionality of ZipFile.writestr as described in the bug.
Member
|
Chriag @srcecde Can you please run the CI once again, on your PR so it is ready for core-review and check-in? |
Member
|
Superseded by #10592. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the cpython/Doc/library/zipfile.rst documentation.
https://bugs.python.org/issue32035