[3.5] bpo-30657: Check & prevent integer overflow in PyString_DecodeEscape (GH-2174)#4664
Merged
Merged
Conversation
Contributor
Author
|
@jaybosamiya I can make you the author of that commit if you'd like, but since it's against a different file, I didn't just cherry-picked it, so I wasn't sure. |
hroncok
changed the title
|
I'm not sure of the convention for cpython when bringing a patch from one version to another, but I'm fine with it either ways. Feel free to keep/change as you see fit :) |
Contributor
Author
|
OK, let's wait what the reviewer says. |
vstinner
reviewed
Dec 4, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Would you mind to rewrite your commit message to mention the original author as the following syntax?
Co-Authored-By: Jay Bosamiya <jaybosamiya@gmail.com>
Fixes possible integer overflow in PyBytes_DecodeEscape. Co-Authored-By: Jay Bosamiya <jaybosamiya@gmail.com>
hroncok
force-pushed
the
fix-issue-30657
branch
from
1981dca to
4ac2528
Compare
Contributor
Author
|
Commit message changed as requested. |
Member
|
@larryhastings: Would you mind to merge this PR? |
Contributor
Author
|
For 3.4: #4758 |
Contributor
Author
|
Thanks @vstinner @larryhastings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes possible integer overflow in PyBytes_DecodeEscape, CVE-2017-1000158.
Original patch by Jay Bosamiya @jaybosamiya in #2174
https://bugs.python.org/issue30657