Skip to content

bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache#4641

Merged
csabella merged 1 commit into
python:masterfrom
ganziqim:master
Jan 26, 2020
Merged

bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache#4641
csabella merged 1 commit into
python:masterfrom
ganziqim:master

Conversation

@ganziqim

@ganziqim ganziqim commented Nov 30, 2017

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@lisroach lisroach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable diff, lazycache should be added to all and the clearcache is improved by using clear().

The extra code changes are just semantics which help code readability without changing any functionality.

@ganziqim

ganziqim commented Dec 3, 2017

Copy link
Copy Markdown
Contributor Author

I've been signed for three times, but the state has not changed

@asvetlov

asvetlov commented Dec 3, 2017

Copy link
Copy Markdown
Contributor

CLA status updated

@ganziqim

ganziqim commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

news entry added

Comment thread Misc/NEWS.d/next/Library/2017-12-04-10-14-23.bpo-32173.e0C5dF.rst Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella

Copy link
Copy Markdown
Contributor

This issue is approved by 2 core developers, but was waiting on an update to the blurb.

@ganziqim Please make the last changes requested by Mariatta, after which I believe this will be ready to merge. Thanks!

@ganziqim
ganziqim force-pushed the master branch 2 times, most recently from d097431 to 4b004f7 Compare March 18, 2019 07:41
@ganziqim

Copy link
Copy Markdown
Contributor Author

This issue is approved by 2 core developers, but was waiting on an update to the blurb.

@ganziqim Please make the last changes requested by Mariatta, after which I believe this will be ready to merge. Thanks!

done.

@csabella

Copy link
Copy Markdown
Contributor

@ganziqim Thanks!

@lisroach @asvetlov I believe Mariatta is out of open source starting today, so, if you can, please review the changes made to the news entry. Thank you!

@csabella
csabella merged commit 4515a59 into python:master Jan 26, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants