bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache#4641
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
lisroach
left a comment
There was a problem hiding this comment.
I think this is a reasonable diff, lazycache should be added to all and the clearcache is improved by using clear().
The extra code changes are just semantics which help code readability without changing any functionality.
|
I've been signed for three times, but the state has not changed |
|
CLA status updated |
|
news entry added |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
This issue is approved by 2 core developers, but was waiting on an update to the blurb. @ganziqim Please make the last changes requested by Mariatta, after which I believe this will be ready to merge. Thanks! |
d097431 to
4b004f7
Compare
done. |
https://bugs.python.org/issue32173