Skip to content

bpo-32108: Fix configparser when a section is assigned to itself. #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 1 commit into from
Closed

bpo-32108: Fix configparser when a section is assigned to itself. #4607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/configparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@

from collections.abc import MutableMapping
from collections import OrderedDict as _default_dict, ChainMap as _ChainMap
from copy import deepcopy
import functools
import io
import itertools
Expand Down Expand Up @@ -964,6 +965,7 @@ def __setitem__(self, key, value):

# XXX this is not atomic if read_dict fails at any point. Then again,
# no update method in configparser is atomic in this implementation.
value = deepcopy(value)
if key == self.default_section:
self._defaults.clear()
elif key in self._sections:
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_configparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,14 @@ def test_case_sensitivity_mapping_access(self):
defaults={"key":"value"})
self.assertTrue("Key" in cf["section"])

def test_assign_itself(self):
cf = self.newconfig()
cf['test'] = {'key': 'value'}
section = cf['test']
section['key'] = 'diffrent'
cf['test'] = section
self.assertEqual(dict(section), {'key': 'diffrent'})

def test_default_case_sensitivity(self):
cf = self.newconfig({"foo": "Bar"})
self.assertEqual(
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2017-11-28-19-51-50.bpo-32108.v4rCnZ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix configparser when a section is assigned to itself. Patched by Dong-
hee Na.