Skip to content

[3.6] bpo-32107 - Backport bitmask check fix (GH-4576)#4591

Merged
warsaw merged 2 commits into
python:3.6from
warsaw:bpo-32107-py36
Nov 29, 2017
Merged

[3.6] bpo-32107 - Backport bitmask check fix (GH-4576)#4591
warsaw merged 2 commits into
python:3.6from
warsaw:bpo-32107-py36

Conversation

@warsaw

@warsaw warsaw commented Nov 27, 2017

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, the change in master broke multiple buildbots.

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@warsaw

warsaw commented Nov 28, 2017

Copy link
Copy Markdown
Member Author

These backport branches won't break the buildbots in the same way, since they remove an unreliable test.

I have made the requested changes; please review again

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@warsaw

warsaw commented Nov 29, 2017

Copy link
Copy Markdown
Member Author

@vstinner @serhiy-storchaka master should be good, so I think we can commit these backports.

@warsaw
warsaw merged commit 23cc8c0 into python:3.6 Nov 29, 2017
@warsaw
warsaw deleted the bpo-32107-py36 branch November 29, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants