Open
Conversation
claudiubelu
force-pushed
the
mock-patch-fix-autospec
branch
2 times, most recently
from
d59fe18 to
797f190
Compare
Contributor
claudiubelu
changed the title
Author
Contributor
|
Or, just merge the 2 and close out the older one? |
Author
|
Hm, tbh, I'd like to keep it simple, since they're both addressing different issues. Anyways, I guess I'll just separate this patch from the other. We'll deal with the merge conflict when it happens. |
Author
|
Actually, nevermind, the unit tests are not passing without the 1st patch. :) |
Contributor
|
alright then. |
Mock can accept an spec object / class as argument, making sure
that accessing attributes that do not exist in the spec will cause an
AttributeError to be raised, but there is no guarantee that the spec's
methods signatures are respected in any way. This creates the possibility
to have faulty code with passing unittests and assertions.
Example:
from unittest import mock
class Something(object):
def foo(self, a, b, c, d):
pass
m = mock.Mock(spec=Something)
m.foo()
Adds the autospec argument to Mock, and its mock_add_spec method.
Passes the spec's attribute with the same name to the child mock (spec-ing
the child), if the mock's autospec is True.
Sets _mock_check_sig if the given spec is callable.
Adds unit tests to validate the fact that the autospec method signatures are
respected.
Currently, when patching methods with autospec, their self / cls
arguments are not consumed, causing call asserts to fail (they
expect an instance / class reference as the first argument).
Example:
from unittest import mock
class Something(object):
def foo(self, a, b, c, d):
pass
patcher = mock.patch.object(Something, 'foo', autospec=True)
patcher.start()
s = Something()
s.foo()
claudiubelu
force-pushed
the
mock-patch-fix-autospec
branch
from
797f190 to
60bbe51
Compare
Contributor
|
@claudiubelu, please resolve the merge conflicts. Thank you! |
Contributor
|
@claudiubelu - it looks like #1982 is with @voidspace and this PR depends on it? Would it be okay to close that one until #1982 is resolved? |
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
stephenfin
added a commit
to stephenfin/cpython
that referenced
this pull request
Mar 27, 2026
Currently, when patching instance / class methods with autospec, their
self / cls arguments are not consumed, causing call asserts to fail
(they expect an instance / class reference as the first argument).
Example:
from unittest import mock
class Something(object):
def foo(self, a, b, c, d):
pass
with mock.patch.object(Something, 'foo', autospec=True):
s = Something()
s.foo()
Fix this by skipping the first argument when presented with a method.
Based on python#4476
Signed-off-by: Stephen Finucane <stephen@that.guru>
Co-authored-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
stephenfin
added a commit
to stephenfin/cpython
that referenced
this pull request
Mar 27, 2026
Currently, when patching instance / class methods with autospec, their
self / cls arguments are not consumed, causing call asserts to fail
(they expect an instance / class reference as the first argument).
Example:
from unittest import mock
class Something(object):
def foo(self, a, b, c, d):
pass
with mock.patch.object(Something, 'foo', autospec=True):
s = Something()
s.foo()
Fix this by skipping the first argument when presented with a method.
Based on python#4476
Signed-off-by: Stephen Finucane <stephen@that.guru>
Co-authored-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-32092: Fixes mock.patch autospec self / cls argument consumption issue
https://bugs.python.org/issue32092
#76273