bpo-32046: Update 2to3 when converts operator.isCallable(obj).#4417
Conversation
corona10
changed the title
|
Could you please update the test (see failures) and docs (in |
a716819 to
cda4cde
Compare
|
@ilevkivskyi |
There was a problem hiding this comment.
Why not use the built-in callable? It’s been re-added to Python 3 a few versions ago.
There was a problem hiding this comment.
Since callable is not available in all 3.x versions, this is probably a safer solution.
There was a problem hiding this comment.
It depends if 2to3 is meant to convert code to Python 3 all versions, Python 3 currently maintained branches, or specific Python 3.X that shipped that particular 2to3. Probably a question for python-dev!
There was a problem hiding this comment.
Should I send this issue to the mailing list?
There was a problem hiding this comment.
I think so, to clarify the compatibility policy of lib2to3.
|
I thought on this article on low version regulations and can automatically trigger highly on focused platforms when fixed properly. |
|
@corona10 Could you please update the PR as suggested on python-dev? |
|
Sure |
|
@ilevkivskyi |
|
@ilevkivskyi |
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
@corona10 Thanks! This looks good to me, but I can't merge since I am not a core dev.
|
@serhiy-storchaka Can you take a look? |
|
Thanks for the patch! |
6 participants
https://bugs.python.org/issue32046