Skip to content

Docs: Fix reference to sys.excepthook as default uncaught exception hook fo… - #4414

Merged
Mariatta merged 1 commit into
python:masterfrom
ashwoods:master
Nov 24, 2017
Merged

Docs: Fix reference to sys.excepthook as default uncaught exception hook fo…#4414
Mariatta merged 1 commit into
python:masterfrom
ashwoods:master

Conversation

@ashwoods

@ashwoods ashwoods commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@ashwoods
ashwoods requested a review from 1st1 as a code owner November 16, 2017 07:35
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 16, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta
Mariatta merged commit f8802d8 into python:master Nov 24, 2017
@miss-islington

miss-islington commented Nov 24, 2017

Copy link
Copy Markdown
Contributor

Thanks @ashwoods for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2017
@ashwoods @miss-islington
Asyncion-Dev docs: Fix the reference to sys.excepthook (pythonGH-4414)
3e622de 
(cherry picked from commit f8802d8)
@bedevere-bot

bedevere-bot commented Nov 24, 2017

Copy link
Copy Markdown

GH-4549 is a backport of this pull request to the 3.6 branch.

@Mariatta

Mariatta commented Nov 24, 2017

Copy link
Copy Markdown
Member

Good catch! Thanks @ashwoods and congrats on your first contribution to CPython 🌮

Mariatta pushed a commit that referenced this pull request Nov 25, 2017
@miss-islington @Mariatta
Asyncion-Dev docs: Fix the reference to sys.excepthook (GH-4414) (GH-…
05ee121 
…4549)

(cherry picked from commit f8802d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes
@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashwoods @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta