Skip to content

bpo-29406: Prevent SSL socket leaking in asyncio #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asvetlov wants to merge 5 commits into from
Closed

bpo-29406: Prevent SSL socket leaking in asyncio #4402

asvetlov wants to merge 5 commits into from

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Nov 15, 2017 •
edited
Loading

@asvetlov asvetlov mentioned this pull request Nov 15, 2017
Closed
@asvetlov asvetlov changed the title Implement bpo-29406: Prevent SSL socket leaking in asyncio bpo-29406: Prevent SSL socket leaking in asyncio Nov 15, 2017
@asvetlov asvetlov self-assigned this Nov 15, 2017
arthurdarcet
arthurdarcet reviewed Nov 15, 2017
View reviewed changes
Lib/asyncio/sslproto.py Outdated
def _on_shutdown_timeout(self):
if self._transport is not None:
self._fatal_error(
futures.TimeoutError(), 'Can not complete shitdown operation')
Copy link
Contributor

@arthurdarcet arthurdarcet Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

@asvetlov asvetlov Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@1st1
Copy link
Member

1st1 commented Jan 20, 2018

Should this PR be closed?

@asvetlov
Copy link
Contributor Author

asvetlov commented Jan 20, 2018

Please let me review first.

@1st1
Copy link
Member

1st1 commented Jan 20, 2018

I thought you've already merged something that fixes this, no?

@1st1
Copy link
Member

1st1 commented May 28, 2018

What's the status of this?

fantix added a commit to fantix/uvloop that referenced this pull request Jul 10, 2018
@fantix
Added handshake_shutdown_timeout and test
42db18c 
See also python/cpython#4402
fantix added a commit to fantix/uvloop that referenced this pull request Jul 10, 2018
@fantix
Added handshake_shutdown_timeout and test
b55f53b 
See also python/cpython#4402
fantix added a commit to fantix/uvloop that referenced this pull request Aug 15, 2018
@fantix
Added handshake_shutdown_timeout and test
66f6ee7 
See also python/cpython#4402
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Dec 8, 2018
@dimaqq
Copy link
Contributor

dimaqq commented Dec 18, 2018

ping...

@vstinner
Copy link
Member

vstinner commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@asvetlov asvetlov closed this Sep 10, 2019
@asvetlov asvetlov deleted the bpo-29406 branch September 12, 2019 12:43
@mcauto
Copy link

mcauto commented Mar 16, 2020 •
edited
Loading

Why closed?

#17975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arthurdarcet arthurdarcet arthurdarcet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@asvetlov asvetlov

Labels

awaiting merge topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@asvetlov @1st1 @dimaqq @vstinner @mcauto @arthurdarcet @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot