Skip to content

gh-76135: Reuse oldkeys if oldkeys->dk_size == newsize. - #4292

Closed
serhiy-storchaka wants to merge 3 commits into
python:mainfrom
serhiy-storchaka:ordered-dict-nodes-table
Closed

serhiy-storchaka wants to merge 3 commits into
python:mainfrom
serhiy-storchaka:ordered-dict-nodes-table

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 6, 2017 •

Copy link
Copy Markdown
Member

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 13, 2022

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 1, 2022
@github-actions

github-actions Bot commented Jan 9, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 9, 2023
@serhiy-storchaka serhiy-storchaka changed the title bpo-31954: Reuse oldkeys if oldkeys->dk_size == newsize. gh-76135: Reuse oldkeys if oldkeys->dk_size == newsize. Aug 12, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 13, 2026
@ambv

ambv commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Rebase review found this PR unportable: Objects/dictobject.c and Objects/odictobject.c were rewritten twice since 2017 (and the header holding its struct change is gone), so this change can no longer be merged with main -- it would need a from-scratch reimplementation against the current design, which explicitly notes oldkeys reuse isn't done. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer.

@ambv ambv closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants