Skip to content

bpo-31905#4180

Closed
Gerardwx wants to merge 1 commit into
python:masterfrom
Gerardwx:fix-issue-31905
Closed

bpo-31905#4180
Gerardwx wants to merge 1 commit into
python:masterfrom
Gerardwx:fix-issue-31905

Conversation

@Gerardwx

@Gerardwx Gerardwx commented Oct 30, 2017

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Gerardwx

Copy link
Copy Markdown
Contributor Author

CLA signed.

@pablogsal

pablogsal commented Oct 30, 2017

Copy link
Copy Markdown
Member

IMHO this doesn't seem a bug (as is already suggested in the issue). Notice that any object (not only None) that doesn't implement _version will raise AttributeError. Checking for None only will be very confusing because it will return False but other things will not.

@vstinner

vstinner commented Nov 6, 2017

Copy link
Copy Markdown
Member

Please elaborate the PR title.

@Mariatta

Copy link
Copy Markdown
Member

Since the issue has been closed, and determined as not a bug, I'm closing this PR.
Thanks!

@Mariatta Mariatta closed this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants