bpo-31890: define METH_STACKLESS#4159
Merged
vstinner merged 2 commits intopython:masterfrom Nov 2, 2017
Merged
Conversation
Add METH_STACKLESS to prevent future collisions.
vstinner
approved these changes
Nov 2, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Since we already have Py_TPFLAGS_HAVE_STACKLESS_EXTENSION, I think that it's ok to add METH_STACKLESS as well.
I just proposed to remove the end of your comment ;-)
Include/methodobject.h
Outdated
| #define METH_FASTCALL 0x0080 | ||
| #endif | ||
|
|
||
| /* This bit is preserved for Stackless Python, next after this is 0x0200 */ |
Member
There was a problem hiding this comment.
IMHO you can remove ", next after this is 0x0200".
Changed comment as suggested by Victor.
embray
pushed a commit
to embray/cpython
that referenced
this pull request
Nov 9, 2017
Add METH_STACKLESS to prevent future collisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add METH_STACKLESS to prevent future collisions.
https://bugs.python.org/issue31890