Skip to content

bpo-27141: Fix collections.UserList and UserDict shallow copy#4094

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
bharel:fix-issue-27141
May 19, 2019
Merged

bpo-27141: Fix collections.UserList and UserDict shallow copy#4094
serhiy-storchaka merged 4 commits into
python:masterfrom
bharel:fix-issue-27141

Conversation

@bharel

@bharel bharel commented Oct 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey guys, fixed according to the requested method.

https://bugs.python.org/issue27141

@bharel
bharel requested a review from rhettinger as a code owner October 23, 2017 21:08
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 23, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@bharel

bharel commented Oct 23, 2017

Copy link
Copy Markdown
Contributor Author

Hello dear bots, I've updated my bpo profile to include my github username, I do have a CLA :-)
I did not update the news however. Doing so right now. Thank you lovely bots for reminding me. :-)

@icemac

icemac commented May 2, 2019

Copy link
Copy Markdown

I stumbled across this issue today while having the same problem as described in zopefoundation/persistent#42. This PR seems reasonable to me and should fix the problem.
What needs to be done to get it merged into master?

@icemac

icemac commented May 17, 2019

Copy link
Copy Markdown

@serhiy-storchaka Thank you for the approval of the PR. What would be the next steps to get it merged?

@csabella
csabella requested review from rhettinger and removed request for rhettinger May 17, 2019 22:41
@serhiy-storchaka
serhiy-storchaka merged commit f4e1bab into python:master May 19, 2019
@serhiy-storchaka serhiy-storchaka added needs backport to 2.7 type-bug An unexpected behavior, bug, or error labels May 19, 2019
@miss-islington

miss-islington commented May 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @bharel for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 19, 2019

Copy link
Copy Markdown
Contributor

Thanks @bharel for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 19, 2019

Copy link
Copy Markdown
Contributor

Sorry, @bharel and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f4e1babf44792bdeb0c01da96821ba0800a51fd8 2.7

@bedevere-bot

bedevere-bot commented May 19, 2019

Copy link
Copy Markdown

GH-13423 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2019
@bharel @miss-islington
bpo-27141: Fix collections.UserList and UserDict shallow copy. (pytho…
501eddf 
…nGH-4094)

(cherry picked from commit f4e1bab)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
miss-islington added a commit that referenced this pull request May 19, 2019
@miss-islington @bharel
bpo-27141: Fix collections.UserList and UserDict shallow copy. (GH-4094)
3645d29 
(cherry picked from commit f4e1bab)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
@bharel
bharel deleted the fix-issue-27141 branch May 19, 2019 14:50
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bharel @the-knights-who-say-ni @icemac @miss-islington @bedevere-bot @serhiy-storchaka