Skip to content

[2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) - #4012

Merged
berkerpeksag merged 1 commit into
python:2.7from
vyas45:bpo-31754
Oct 16, 2017
Merged

[2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993)#4012
berkerpeksag merged 1 commit into
python:2.7from
vyas45:bpo-31754

Conversation

@vyas45

@vyas45 vyas45 commented Oct 16, 2017

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@vyas45

vyas45 commented Oct 16, 2017

Copy link
Copy Markdown
Contributor Author

@berkerpeksag here is the 2.7 backport.

Thanks !

@berkerpeksag berkerpeksag changed the title [3.6] bpo-31754:(Backport)Fix the PyBuffer Documentation (GH-3993) [2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides Oct 16, 2017

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I've just renamed the title and add "[2.7]".

@vyas45

vyas45 commented Oct 16, 2017

Copy link
Copy Markdown
Contributor Author

Thanks @berkerpeksag for the help on the first commit. Will definitely help me with subsequent contributions.

@Mariatta Mariatta changed the title [2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides [2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) Oct 16, 2017
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir labels Oct 16, 2017
@berkerpeksag

Copy link
Copy Markdown
Member

Thanks @berkerpeksag for the help on the first commit. Will definitely help me with subsequent contributions.

No problem :) Please sign the CLA for your future contributions. Otherwise, we can't accept your non-trival patches.

@berkerpeksag
berkerpeksag merged commit 50cef52 into python:2.7 Oct 16, 2017
@vyas45

vyas45 commented Oct 16, 2017

Copy link
Copy Markdown
Contributor Author

I think i did so over the weekend. On my account I see : Contributor Form Received . Probably need to wait for the approval ?

@vyas45
vyas45 deleted the bpo-31754 branch October 16, 2017 18:26
@berkerpeksag

Copy link
Copy Markdown
Member

Yes, it usually take a couple days to verify CLA forms.

@vyas45

vyas45 commented Oct 16, 2017

Copy link
Copy Markdown
Contributor Author

Got it. Will wait for the approval.

Have a great day and week ahead !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants