Skip to content

[3.6] bpo-31676: Fix test_imp.test_load_source() side effect (GH-3871) - #3988

Merged
Mariatta merged 1 commit into
python:3.6from
miss-islington:backport-a505ecd-3.6
Oct 18, 2017
Merged

Mariatta merged 1 commit into
python:3.6from
miss-islington:backport-a505ecd-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 13, 2017 •

Copy link
Copy Markdown
Contributor

test_load_source() now replaces the current name module with a
temporary module to prevent side effects.
(cherry picked from commit a505ecd)

https://bugs.python.org/issue31676

…H-3871)

test_load_source() now replaces the current __name__ module with a
temporary module to prevent side effects.
(cherry picked from commit a505ecd)

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@Haypo: Backport status check is done, and it's a success ✅ .

@Mariatta
Mariatta merged commit 1781480 into python:3.6 Oct 18, 2017
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks, @Mariatta!

@miss-islington
miss-islington deleted the backport-a505ecd-3.6 branch October 18, 2017 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants