Skip to content

[3.6] bpo-25588: Fix regrtest when run inside IDLE (GH-3962) - #3987

Merged
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-ccef823-3.6
Oct 13, 2017
Merged

vstinner merged 1 commit into
python:3.6from
miss-islington:backport-ccef823-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 13, 2017 •

Copy link
Copy Markdown
Contributor

When regrtest in run inside IDLE, sys.stdout and sys.stderr are not
TextIOWrapper objects and have no file descriptor associated:
sys.stderr.fileno() raises io.UnsupportedOperation.

Disable faulthandler and don't replace sys.stdout in that case.
(cherry picked from commit ccef823)

https://bugs.python.org/issue25588

When regrtest in run inside IDLE, sys.stdout and sys.stderr are not
TextIOWrapper objects and have no file descriptor associated:
sys.stderr.fileno() raises io.UnsupportedOperation.

Disable faulthandler and don't replace sys.stdout in that case.
(cherry picked from commit ccef823)

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@Haypo: Backport status check is done, and it's a success ✅ .

@vstinner
vstinner merged commit 6234e90 into python:3.6 Oct 13, 2017
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks, @Haypo!

@miss-islington
miss-islington deleted the backport-ccef823-3.6 branch October 13, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants