Skip to content

[2.7] bpo-31271: Fix an assertion failure in io.TextIOWrapper.write. (GH-3201) #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Nov 7, 2017
Merged

[2.7] bpo-31271: Fix an assertion failure in io.TextIOWrapper.write. (GH-3201) #3951

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b54430e
init commit
orenmn Oct 11, 2017
ae73455
fix test comment
orenmn Oct 11, 2017
98eae4c
fix typo
orenmn Oct 11, 2017
9f3a245
remove redundant underscore
orenmn Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,6 +2666,22 @@ class NonbytesStream(self.StringIO):
t = self.TextIOWrapper(NonbytesStream('a'))
self.assertEqual(t.read(), u'a')

def test_illegal_encoder(self):
# bpo-31271: A TypeError should be raised in case the return value of
# encoder's encode() is invalid.
class BadEncoder:
def encode(self, dummy):
return u'spam'
def get_bad_encoder(dummy):
return BadEncoder()
rot13 = codecs.lookup("rot13")
with support.swap_attr(rot13, '_is_text_encoding', True), \
support.swap_attr(rot13, 'incrementalencoder', get_bad_encoder):
t = io.TextIOWrapper(io.BytesIO(b'foo'), encoding="rot13")
with self.assertRaises(TypeError):
t.write('bar')
t.flush()

def test_illegal_decoder(self):
# Issue #17106
# Bypass the early encoding check added in issue 20404
Expand Down