Skip to content

bpo-31619 Compare only the number of digits in the check for overflow - #3816

Closed
nitishch wants to merge 1 commit into
python:masterfrom
nitishch:bpo-31619
Closed

nitishch wants to merge 1 commit into
python:masterfrom
nitishch:bpo-31619

Conversation

@nitishch

@nitishch nitishch commented Sep 29, 2017 •

Copy link
Copy Markdown
Contributor

The issue was because the comparison was done between the number of digits and the length of the string. When the string can have chars other than digits, this comparison doesn't hold. Compare digits to digits.

Issue: bpo-31619

https://bugs.python.org/issue31619

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@taleinat

Copy link
Copy Markdown
Contributor

A different fix for this has been implemented in PR #3827 which has been accepted and merged.

See relevant conversation in the BPO issue.

@taleinat taleinat closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants