Skip to content

bpo-31500: IDLE: Scale default fonts on HiDPI displays. #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
Sep 21, 2017
Merged

bpo-31500: IDLE: Scale default fonts on HiDPI displays. #3639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a58e407
bpo-31500: IDLE: Scale default fonts on HiDPI displays.
serhiy-storchaka Sep 18, 2017
61d3d28
Move fix_scaling to run.py.
serhiy-storchaka Sep 19, 2017
3c87c59
Do not hardcode the size of config dialog.
serhiy-storchaka Sep 19, 2017
2bece79
Scale fonts only on HiDPI displays.
serhiy-storchaka Sep 19, 2017
c6db58c
Update configdialog.py
terryjreedy Sep 19, 2017
223caaa
Merge remote-tracking branch 'origin/master' into pr_3639
terryjreedy Sep 20, 2017
3eb0894
Downscale fonts to about 100 DPI.
serhiy-storchaka Sep 20, 2017
59847c2
Minor change.
serhiy-storchaka Sep 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/filelist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ def canonize(self, filename):

def _test():
from idlelib.editor import fixwordbreaks
from idlelib.run import fix_scaling
import sys
root = Tk()
fix_scaling(root)
fixwordbreaks(root)
root.withdraw()
flist = FileList(root)
Expand Down
4 changes: 4 additions & 0 deletions Lib/idlelib/pyshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
if TkVersion < 8.5:
root = Tk() # otherwise create root in main
root.withdraw()
from idlelib.run import fix_scaling
fix_scaling(root)
tkMessageBox.showerror("Idle Cannot Start",
"Idle requires tcl/tk 8.5+, not %s." % TkVersion,
parent=root)
Expand Down Expand Up @@ -1457,6 +1459,8 @@ def main():
NoDefaultRoot()
root = Tk(className="Idle")
root.withdraw()
from idlelib.run import fix_scaling
fix_scaling(root)

# set application icon
icondir = os.path.join(os.path.dirname(__file__), 'Icons')
Expand Down
13 changes: 13 additions & 0 deletions Lib/idlelib/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ def show_socket_error(err, address):
import tkinter
from tkinter.messagebox import showerror
root = tkinter.Tk()
fix_scaling(root)
root.withdraw()
msg = f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"\
f"Fatal OSError #{err.errno}: {err.strerror}.\n"\
Expand Down Expand Up @@ -277,6 +278,18 @@ def exit():
sys.exit(0)


def fix_scaling(root):
"""Scale fonts on HiDPI displays."""
import tkinter.font
scaling = float(root.tk.call('tk', 'scaling'))
if scaling > 1.4:
for name in tkinter.font.names(root):
font = tkinter.font.Font(root=root, name=name, exists=True)
size = int(font['size'])
if size < 0:
font['size'] = round(-0.75*size)


class MyRPCServer(rpc.RPCServer):

def handle_error(self, request, client_address):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2017-09-18-10-43-03.bpo-31500.Y_YDxA.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Default fonts now are scaled on HiDPI displays.