Skip to content

bpo-31474: Fix -Wint-in-bool-context warnings - #3581

Merged
tiran merged 1 commit into
python:2.7from
tiran:bpo-31474-warnings
Sep 15, 2017
Merged

tiran merged 1 commit into
python:2.7from
tiran:bpo-31474-warnings

Conversation

@tiran

@tiran tiran commented Sep 14, 2017 •

Copy link
Copy Markdown
Member

@tiran tiran added the type-bug An unexpected behavior, bug, or error label Sep 14, 2017
Comment thread Objects/stringlib/formatter.h Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that prefix is NULL?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format_float_internal() calls the fill function with prefix=NULL.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
tiran force-pushed the bpo-31474-warnings branch from e160db8 to 14c9588 Compare September 15, 2017 18:14
@tiran tiran changed the title bpo-31474: Fix -Wnonnull and -Wint-in-bool-context warnings bpo-31474: Fix -Wint-in-bool-context warnings Sep 15, 2017
@tiran

tiran commented Sep 15, 2017

Copy link
Copy Markdown
Member Author

I'm going to fix the -Wint-in-bool-context warnings first as they are most annoying. Let's figure out the other warnings in a different PR.

@tiran
tiran merged commit fd39e2a into python:2.7 Sep 15, 2017
@tiran
tiran deleted the bpo-31474-warnings branch September 15, 2017 18:27

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants