[3.6] bpo-30923: Silence fall-through warnings included in -Wextra since gcc-7.0#3518
Merged
vstinner merged 3 commits intopython:3.6from Sep 12, 2017
vstinner:fall_through36
Merged
[3.6] bpo-30923: Silence fall-through warnings included in -Wextra since gcc-7.0#3518vstinner merged 3 commits intopython:3.6from vstinner:fall_through36
vstinner merged 3 commits intopython:3.6from
vstinner:fall_through36
Conversation
added 3 commits
September 12, 2017 19:37
Member
|
Usually we don't backport changes that just silence compiler warnings. |
Contributor
|
It's a double edged sword: If we don't backport, other backports become more difficult because of conflicts. Technically we should take out |
skrah
approved these changes
Sep 12, 2017
Member
Author
IMHO the change is simple enough to justify a backport. I would like to fix these warnings to be able to detect more serious warnings.
I read it and it seems safe. |
Contributor
|
Thanks, @Haypo! |
Member
Author
|
Thanks for the review @skrah. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30923