Skip to content

gh-91398: Remove IDLE shell sidebar padding#32363

Open
BA-24 wants to merge 5 commits into
python:mainfrom
BA-24:patch-1
Open

gh-91398: Remove IDLE shell sidebar padding#32363
BA-24 wants to merge 5 commits into
python:mainfrom
BA-24:patch-1

Conversation

@BA-24

@BA-24 BA-24 commented Apr 6, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions.

Changing this line of code solves this issue and leaves the color choices up to the user.

#89614, #91398

@BA-24
Remove white bar
b25db6a 
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions.

Changing this line of code solves this issue and leaves the color choices up to the user.
@BA-24 BA-24 requested a review from terryjreedy as a code owner April 6, 2022 13:57
@the-knights-who-say-ni

This comment was marked as outdated.

Sign in to view
@ambv ambv closed this Apr 10, 2022
@ambv ambv reopened this Apr 10, 2022
terryjreedy
terryjreedy requested changes Apr 11, 2022
View reviewed changes

@terryjreedy terryjreedy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects the shell sidebar, which is the subject of bpo-45451. I made the change I requested.

On my Windows with dark theme, I prefer the change. But change needs evaluation on light and dark themes on all 3 major OSes. Will ask OP of issue for opinion. So not approved yet.

Comment thread Lib/idlelib/sidebar.py Outdated
@terryjreedy terryjreedy changed the title Remove white bar bpo-45451: Remove IDLE shell sidebar padding Apr 11, 2022
@python python deleted a comment from bedevere-bot Apr 11, 2022
@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error needs backport to 3.9 needs backport to 3.10 only security fixes topic-IDLE 3.11 only security fixes 3.10 only security fixes 3.9 (EOL) end of life labels Apr 11, 2022
@terryjreedy

terryjreedy commented Apr 11, 2022

Copy link
Copy Markdown
Member

@ambv This should be linked to the new GH issue when available. I overwrote the proposed change and will add blurb before merging.

@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@terryjreedy terryjreedy changed the title bpo-45451: Remove IDLE shell sidebar padding gh-89614: Remove IDLE shell sidebar padding May 17, 2022
@terryjreedy terryjreedy added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error topic-IDLE labels May 17, 2022
@BA-24

BA-24 commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

I don't believe that this is needed for 3.9. It is certainly more of an issue for 3.10+.

There is a new CI button that requires CLA be signed, even for something trivial that should not require it. Adding a possibly false CLA signed label does not seem to fix that. If no signature, any workaround other than making a new PR myself?

That's my bad. I messed up the CLA thing, and, long story short, I ended up making a new identical issue on the bugs.python.org thing that can be found here

@terryjreedy terryjreedy changed the title gh-89614: Remove IDLE shell sidebar padding gh-91398: Remove IDLE shell sidebar padding May 21, 2022
@ambv

ambv commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

@BA-24 could you try signing the CLA again? This should work now.

@BA-24

BA-24 commented Jun 23, 2022

Copy link
Copy Markdown
Author

Should be signed now

@ambv ambv closed this Jul 5, 2022
@ambv ambv reopened this Jul 5, 2022
@python python deleted a comment from bedevere-bot Sep 18, 2022
@python python deleted a comment from bedevere-bot Sep 18, 2022
@BA-24

BA-24 commented Oct 31, 2022

Copy link
Copy Markdown
Author

Hey, just updated to 3.11, is this getting merged or will I have to keep modifying the file manually?

@iritkatriel

iritkatriel commented Nov 25, 2022

Copy link
Copy Markdown
Member

Hey, just updated to 3.11, is this getting merged or will I have to keep modifying the file manually?

CI is failing because the news item is missing.

@terryjreedy

terryjreedy commented Nov 25, 2022

Copy link
Copy Markdown
Member

I am still planning to look at this soon.

@BA-24

BA-24 commented Jan 2, 2023

Copy link
Copy Markdown
Author

Hey, just updated to 3.11, is this getting merged or will I have to keep modifying the file manually?

CI is failing because the news item is missing.

As far as I'm concerned it's a typo and does not need a news entry.

@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 8, 2023
@BA-24

BA-24 commented Mar 13, 2024

Copy link
Copy Markdown
Author

Hey, just updated to 3.12 and it seems this change still hasn't gone through. Updates?

@hugovk hugovk removed the needs backport to 3.11 only security fixes label Apr 22, 2024
@StanFromIreland

StanFromIreland commented Feb 4, 2025

Copy link
Copy Markdown
Member

I am still planning to look at this soon. (2022)

@terryjreedy Just a little reminder :) Is it possible for you to run all the actions (I do not have the permissions to do this) so we can see the current state of the PR?

StanFromIreland
StanFromIreland approved these changes Feb 5, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terryjreedy you asked for previews on major oss, here is Linux.

Classic

image

Dark

image

@BA-24

BA-24 commented Feb 5, 2025

Copy link
Copy Markdown
Author

@terryjreedy you asked for previews on major oss, here is Linux.

I think this looks great!

@python python deleted a comment Apr 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 23, 2025
Open
@bedevere-app

bedevere-app Bot commented Apr 23, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

@terryjreedy terryjreedy

Labels

awaiting merge stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@BA-24 @the-knights-who-say-ni @terryjreedy @ambv @bedevere-bot @iritkatriel @StanFromIreland @hugovk @ezio-melotti