Skip to content

bpo-47005: Improve performance of bytearray_repeat and bytearray_irepeat#31856

Merged
sweeneyde merged 3 commits intopython:mainfrom
eendebakpt:bytearray_repeat
Mar 17, 2022
Merged

bpo-47005: Improve performance of bytearray_repeat and bytearray_irepeat#31856
sweeneyde merged 3 commits intopython:mainfrom
eendebakpt:bytearray_repeat

Conversation

@eendebakpt
Copy link
Copy Markdown
Contributor

@eendebakpt eendebakpt commented Mar 13, 2022 •
edited by bedevere-bot
Loading

The bytearray_repeat and bytearray_irepeat are inefficient for small arrays and a high number of repeats.
This can be improved by using the same approach is in the corresponding bytes_repeat method.

Microbenchmarks:

python -m pyperf timeit "b=bytearray([1,2,])*100" 
python -m pyperf timeit "b=bytearray([1,2,])*1000"

Results:

Mean +- std dev: [base100] 479 ns +- 29 ns -> [patch100] 274 ns +- 18 ns: 1.75x faster
Mean +- std dev: [base1000] 2.58 us +- 0.18 us -> [patch1000] 399 ns +- 26 ns: 6.46x faster

https://bugs.python.org/issue47005

https://bugs.python.org/issue47005

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Mar 13, 2022

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@eendebakpt

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

sweeneyde
sweeneyde reviewed Mar 13, 2022
View reviewed changes
@sweeneyde
Copy link
Copy Markdown
Member

sweeneyde commented Mar 13, 2022

Thanks! The CLA process takes a couple of business days to go through, so we'll wait for that. Please also add a NEWS entry: you can either use the blurb tool or use the link https://blurb-it.herokuapp.com/

methane
methane approved these changes Mar 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sweeneyde sweeneyde merged commit ac8308d into python:main Mar 17, 2022
@eendebakpt eendebakpt deleted the bytearray_repeat branch March 18, 2022 09:57
@eendebakpt eendebakpt mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneyde sweeneyde sweeneyde left review comments

@methane methane methane approved these changes

@rhettinger rhettinger rhettinger approved these changes

+1 more reviewer

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eendebakpt @the-knights-who-say-ni @sweeneyde @methane @rhettinger @raghavthind2005 @bedevere-bot