Skip to content

Remove new line in pickle error message#31782

Merged
iritkatriel merged 6 commits into
python:mainfrom
harshil21:patch-1
Nov 7, 2022
Merged

Remove new line in pickle error message#31782
iritkatriel merged 6 commits into
python:mainfrom
harshil21:patch-1

Conversation

@harshil21

Copy link
Copy Markdown
Contributor

Removes the new line in the error message. Encountered this while testing something and found it a little weird that there would be a new line character when the error message is short anyway.

@harshil21

Copy link
Copy Markdown
Contributor Author

Hi, is this change going to be implemented? If not, I'll just close.

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt we need a news entry for this. Also docs seem to be failing.

@harshil21

Copy link
Copy Markdown
Contributor Author

I think it's failing because there isn't an issue for this PR. Maybe I should delete the NEWS.d entry then?

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, remove the news entry

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@iritkatriel

Copy link
Copy Markdown
Member

@serhiy-storchaka - as someone who's been looking at pickle issue recently, do you see any problem with this change? Does it need a news entry?

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a very old code. It was added in fdde96c.

I do not know reasons of adding a newline at the first place, but the change LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants