Docstring: replace pysqlite with sqlite3#31758
Merged
JelleZijlstra merged 3 commits intopython:mainfrom Mar 9, 2022
Merged
Conversation
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword the same docstring with "does nothing" to "is a no-op" to align them with the docs.
erlend-aasland
force-pushed
the
sqlite-pysqlite
branch
from
24bfc2c to
ab174fb
Compare
Contributor
Author
|
@JelleZijlstra: I believe this is one of the rare cases where skip issue can be applied. Please shout out if you disagree. |
kumaraditya303
requested changes
Mar 8, 2022
Contributor
Author
|
We could backport this. |
JelleZijlstra
added
needs backport to 3.9
needs backport to 3.10
JelleZijlstra
approved these changes
Mar 8, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Agree. @gvanrossum planning to merge this minor sqlite change
gvanrossum
approved these changes
Mar 8, 2022
Contributor
|
Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Contributor
|
Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to |
Contributor
|
Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the |
Member
|
I'll backport |
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Mar 9, 2022
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
|
GH-31777 is a backport of this pull request to the 3.10 branch. |
|
GH-31778 is a backport of this pull request to the 3.9 branch. |
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Mar 9, 2022
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
asvetlov
pushed a commit
that referenced
this pull request
Mar 9, 2022
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.
JelleZijlstra
added a commit
that referenced
this pull request
Mar 9, 2022
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
JelleZijlstra
added a commit
that referenced
this pull request
Mar 9, 2022
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…onGH-31778) Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings.
Also align the docs with the docstrings for the two affected methods.