Skip to content

bpo-46936: Update grammar_grapher with the new forced (&&) directive#31704

Merged
pablogsal merged 1 commit into
python:mainfrom
lucach:fix_grammar_grapher
Mar 6, 2022
Merged

bpo-46936: Update grammar_grapher with the new forced (&&) directive#31704
pablogsal merged 1 commit into
python:mainfrom
lucach:fix_grammar_grapher

Conversation

@lucach

@lucach lucach commented Mar 6, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

The grammar_grapher.pyutility has not been updated after the introduction of the new "forced" directive ('&&') in the grammar (see #24292) and fails to visualize the current Python grammar.

https://bugs.python.org/issue46936

Automerge-Triggered-By: GH:pablogsal

@pablogsal

pablogsal commented Mar 6, 2022

Copy link
Copy Markdown
Member

@lucach Can you submit also a PR against the pegen repo?

That's in https://github.com/we-like-parsers/pegen

@pablogsal
pablogsal merged commit 7f07b5e into python:main Mar 6, 2022
@miss-islington

miss-islington commented Mar 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @lucach for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 6, 2022

Copy link
Copy Markdown
Contributor

Sorry @lucach and @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7f07b5ee9c2d17f837c44440bf066c73f92dac14 3.10

@python python deleted a comment from bedevere-bot Mar 6, 2022
@pablogsal

pablogsal commented Mar 6, 2022

Copy link
Copy Markdown
Member

Sorry @lucach and @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7f07b5ee9c2d17f837c44440bf066c73f92dac14 3.10

@lucach could you make the backport following these instructions, please? Thanks!

lucach added a commit to lucach/cpython that referenced this pull request Mar 7, 2022
@lucach
[3.10] Update grammar_grapher with the new forced (&&) directive (pyt…
0432b9b 
…honGH-31704)

(cherry picked from commit 7f07b5e)

Co-authored-by: Luca Chiodini <luca@chiodini.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 7, 2022
@bedevere-bot

bedevere-bot commented Mar 7, 2022

Copy link
Copy Markdown

GH-31719 is a backport of this pull request to the 3.10 branch.

@lucach lucach mentioned this pull request Mar 7, 2022
Merged
@lucach

lucach commented Mar 7, 2022

Copy link
Copy Markdown
Contributor Author

Done (both on pegen and on the 3.10 branch)... hopefully without too many mistakes. Thanks @pablogsal!

@pablogsal

pablogsal commented Mar 7, 2022

Copy link
Copy Markdown
Member

Thanks @lucach

pablogsal pushed a commit that referenced this pull request Mar 7, 2022
@lucach
[3.10] Update grammar_grapher with the new forced (&&) directive (GH-…
0ff033b 
…31704) (GH-31719)

(cherry picked from commit 7f07b5e)

Co-authored-by: Luca Chiodini <luca@chiodini.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucach @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni