Skip to content

bpo-46712: Let generate_global_objects.py Run on Earlier Python Versions #31637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 3 commits into from
Mar 1, 2022
Merged

bpo-46712: Let generate_global_objects.py Run on Earlier Python Versions #31637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd08fae
Let generate_global_objects.py run on earlier Python versions.
ericsnowcurrently Mar 1, 2022
a44f634
Make sure deepfreeze runs before regen-global-objects.
ericsnowcurrently Mar 1, 2022
9746895
Drop accidental IDs.
ericsnowcurrently Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ regen-importlib: regen-frozen
# Global objects

.PHONY: regen-global-objects
regen-global-objects: $(srcdir)/Tools/scripts/generate_global_objects.py
regen-global-objects: regen-deepfreeze $(srcdir)/Tools/scripts/generate_global_objects.py
$(PYTHON_FOR_REGEN) $(srcdir)/Tools/scripts/generate_global_objects.py

############################################################################
Expand Down
2 changes: 1 addition & 1 deletion Tools/scripts/generate_global_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def generate_runtime_init(identifiers, strings):
printer.write(after)


def get_identifiers_and_strings() -> tuple[set[str], dict[str, str]]:
def get_identifiers_and_strings() -> 'tuple[set[str], dict[str, str]]':
identifiers = set(IDENTIFIERS)
strings = dict(STRING_LITERALS)
for name, string, *_ in iter_global_strings():
Expand Down