[3.8] bpo-46784: Add newly exported expat symbols to the namespace. (GH-31397) #31419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The expat upgrade was backported as a security fix within the past year, this goes along with that. Unclear how often people actually run into the underlying exported symbol conflict issue in practice. |
Contributor
Author
|
@yilei: Status check is done, and it's a failure ❌ . |
…GH-31397) The libexpat 2.4.1 upgrade from introduced the following new exported symbols: * `testingAccountingGetCountBytesDirect` * `testingAccountingGetCountBytesIndirect` * `unsignedCharToPrintable` * `XML_SetBillionLaughsAttackProtectionActivationThreshold` * `XML_SetBillionLaughsAttackProtectionMaximumAmplification` We need to adjust [Modules/expat/pyexpatns.h](https://github.com/python/cpython/blob/master/Modules/expat/pyexpatns.h) (The newer libexpat upgrade has no new symbols). Automerge-Triggered-By: GH:gpshead (cherry picked from commit 6312c10) Co-authored-by: Yilei "Dolee" Yang <yileiyang@google.com>
ambv
force-pushed
the
backport-6312c10-3.8
branch
from
d41f642 to
408cc84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libexpat 2.4.1 upgrade from introduced the following new exported symbols:
testingAccountingGetCountBytesDirecttestingAccountingGetCountBytesIndirectunsignedCharToPrintableXML_SetBillionLaughsAttackProtectionActivationThresholdXML_SetBillionLaughsAttackProtectionMaximumAmplificationWe need to adjust Modules/expat/pyexpatns.h
(The newer libexpat upgrade has no new symbols).
Automerge-Triggered-By: GH:gpshead
(cherry picked from commit 6312c10)
Co-authored-by: Yilei "Dolee" Yang yileiyang@google.com
https://bugs.python.org/issue46784