Fix a minor grammar issue in the logging cookbook#3136
Merged
brettcannon merged 1 commit intomasterfrom Aug 18, 2017
Merged
Conversation
Contributor
|
Working on translating this page in French, I don't understand the meaning of this particular clause. It seems to me as a word is missing ("there would be no XXX changing this while preserving backward compatibility", XXX would be "benefit", "advantage", ...). NB : of course, English is not my mother tongue. |
Member
|
This is an idiomatic phrase; it means "This would not be changed while...". Maybe it's informal or only North American English; I've definitely heard it before in contexts like "there was no persuading her". |
Contributor
|
Thank you Jelle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.