bpo-46679: Don't ignore timeout argument in test.support.wait_process. #31205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Feb 11, 2022
| @@ -0,0 +1,2 @@ | |||
| The function ``wait_process`` in ``Lib/test/support/__init__.py`` no longer | |||
Member
There was a problem hiding this comment.
NEWS are not required for test-only changes. We need them for user-facing changes only 🙂
Contributor
Author
There was a problem hiding this comment.
Good to know! Thanks! :)
Contributor
Author
|
@kumaraditya303 Done. :) |
Contributor
|
The wait_process function has changed significantly since your changes in the latest 3.12 could you please check? |
kumaraditya303
requested review from
vstinner
and removed request for
vstinner
Member
|
I fixed this issue with commit 0ba8027. But IMO it's still interesting to fix this typo in Python 3.10 and 3.11. Can you please create a PR for the 3.11 branch? |
Contributor
|
Closing as it is fixed on main. If you are interested, feel free to create 3.11 backport as Victor suggested. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
wait_processinLib/test/support/__init__.pyignores itstimeoutargument. This argument is useful, for example, in tests that need to determine whether a deadlock has been fixed (e.g., the test added in #30310).https://bugs.python.org/issue46679