Skip to content

bpo-46676: Make ParamSpec args and kwargs equal to themselves #31203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 7 commits into from
Feb 8, 2022
Merged

bpo-46676: Make ParamSpec args and kwargs equal to themselves #31203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10a1640
Make ParamSpec args and kwargs equal to themselves
GBeauregard Feb 7, 2022
244a64f
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 7, 2022
47d0b78
Update 2022-02-07-19-20-42.bpo-46676.3Aws1o.rst
GBeauregard Feb 7, 2022
88177f8
Update 2022-02-07-19-20-42.bpo-46676.3Aws1o.rst
GBeauregard Feb 7, 2022
71219e6
add tests for non-equality
GBeauregard Feb 7, 2022
0274d79
Update 2022-02-07-19-20-42.bpo-46676.3Aws1o.rst
GBeauregard Feb 8, 2022
e8a1cda
add tests to cover NotImplemented
GBeauregard Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4924,12 +4924,20 @@ def test_valid_uses(self):

def test_args_kwargs(self):
P = ParamSpec('P')
P_2 = ParamSpec('P_2')
self.assertIn('args', dir(P))
self.assertIn('kwargs', dir(P))
self.assertIsInstance(P.args, ParamSpecArgs)
self.assertIsInstance(P.kwargs, ParamSpecKwargs)
self.assertIs(P.args.__origin__, P)
self.assertIs(P.kwargs.__origin__, P)
self.assertEqual(P.args, P.args)
Comment thread
GBeauregard marked this conversation as resolved.
self.assertEqual(P.kwargs, P.kwargs)
self.assertNotEqual(P.args, P_2.args)
self.assertNotEqual(P.kwargs, P_2.kwargs)
Comment thread
GBeauregard marked this conversation as resolved.
self.assertNotEqual(P.args, P.kwargs)
self.assertNotEqual(P.kwargs, P.args)
self.assertNotEqual(P.args, P_2.kwargs)
self.assertEqual(repr(P.args), "P.args")
self.assertEqual(repr(P.kwargs), "P.kwargs")

Expand Down
10 changes: 10 additions & 0 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,11 @@ def __init__(self, origin):
def __repr__(self):
return f"{self.__origin__.__name__}.args"

def __eq__(self, other):
if not isinstance(other, ParamSpecArgs):
return NotImplemented
return self.__origin__ == other.__origin__


class ParamSpecKwargs(_Final, _Immutable, _root=True):
"""The kwargs for a ParamSpec object.
Expand All @@ -856,6 +861,11 @@ def __init__(self, origin):
def __repr__(self):
return f"{self.__origin__.__name__}.kwargs"

def __eq__(self, other):
if not isinstance(other, ParamSpecKwargs):
return NotImplemented
return self.__origin__ == other.__origin__


class ParamSpec(_Final, _Immutable, _TypeVarLike, _root=True):
"""Parameter specification variable.
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-02-07-19-20-42.bpo-46676.3Aws1o.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make :data:`typing.ParamSpec` args and kwargs equal to themselves. Patch by Gregory Beauregard.