bpo-46672: fix NameError in asyncio.gather if type check fails#31187
Merged
Conversation
AlexWaygood
reviewed
Feb 7, 2022
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
sobolevn
commented
Feb 7, 2022
JelleZijlstra
approved these changes
Feb 19, 2022
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Confirmed that the new test fails without the fix.
asvetlov
approved these changes
Feb 20, 2022
Contributor
Contributor
|
Sorry, @sobolevn and @asvetlov, I could not cleanly backport this to |
|
GH-31440 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2022
…ythonGH-31187) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 4ab8167) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-31441 is a backport of this pull request to the 3.9 branch. |
asvetlov
pushed a commit
to asvetlov/cpython
that referenced
this pull request
Feb 20, 2022
…ils (pythonGH-31187) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>. (cherry picked from commit 4ab8167) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
asvetlov
pushed a commit
that referenced
this pull request
Feb 20, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ils (pythonGH-31187) (pythonGH-31441) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am a bit unsure about the full coverage of
if outer is None or outer.done():condition. Does it cover all corner cases?https://bugs.python.org/issue46672