Skip to content

bpo-45773: Remove invalid peephole optimizations#31066

Merged
markshannon merged 2 commits into
python:mainfrom
brandtbucher:peephole-fix
Feb 3, 2022
Merged

bpo-45773: Remove invalid peephole optimizations#31066
markshannon merged 2 commits into
python:mainfrom
brandtbucher:peephole-fix

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Feb 1, 2022

Copy link
Copy Markdown
Member

The good news is that I can't get the compiler to actually emit these particular jump sequences.

https://bugs.python.org/issue45773

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes labels Feb 1, 2022
@markshannon markshannon self-assigned this Feb 2, 2022
@markshannon

Copy link
Copy Markdown
Member

👍

@markshannon
markshannon merged commit e0433c1 into python:main Feb 3, 2022
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @brandtbucher and @markshannon, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e0433c1e70254d4d0357a9e14596929a04bdf769 3.10

@brandtbucher brandtbucher added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Feb 3, 2022
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-31101 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 3, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2022
(cherry picked from commit e0433c1)

Co-authored-by: Brandt Bucher <brandt@python.org>
miss-islington added a commit that referenced this pull request Feb 3, 2022
(cherry picked from commit e0433c1)

Co-authored-by: Brandt Bucher <brandt@python.org>
@brandtbucher
brandtbucher deleted the peephole-fix branch July 21, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants