Skip to content

bpo-46557: Log captured warnings without format string (GH-30975) #30975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 6 commits into from
Mar 15, 2022
Merged

bpo-46557: Log captured warnings without format string (GH-30975) #30975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ae3478
bpo-46557: Log captured warnings without format string
mnito Jan 28, 2022
0f82fff
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 28, 2022
f777c46
Add period after blurb sentence
mnito Jan 28, 2022
7382892
Refine blurb
mnito Jan 28, 2022
eb93483
Add clarifying comment
mnito Jan 28, 2022
8486959
Reference bpo issue number in comment
mnito Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/logging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2246,7 +2246,9 @@ def _showwarning(message, category, filename, lineno, file=None, line=None):
logger = getLogger("py.warnings")
if not logger.handlers:
logger.addHandler(NullHandler())
logger.warning("%s", s)
# bpo-46557: Log str(s) as msg instead of logger.warning("%s", s)
# since some log aggregation tools group logs by the msg arg
Comment thread
vsajip marked this conversation as resolved.
logger.warning(str(s))
Comment thread
ericvsmith marked this conversation as resolved.

def captureWarnings(capture):
"""
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-01-28-01-23-25.bpo-46557.XSbhyQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Warnings captured by the logging module are now logged without a format string to prevent systems that group logs by the msg argument from grouping captured warnings together.