Skip to content

bpo-31191: Fix grammar in threading.Barrier docs#3080

Merged
Mariatta merged 2 commits intopython:masterfrom
schedutron:master
Aug 14, 2017
Merged

bpo-31191: Fix grammar in threading.Barrier docs#3080
Mariatta merged 2 commits intopython:masterfrom
schedutron:master

Conversation

@schedutron
Copy link
Copy Markdown
Contributor

@schedutron schedutron commented Aug 12, 2017

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@schedutron schedutron closed this Aug 12, 2017
@schedutron schedutron reopened this Aug 12, 2017
@schedutron schedutron changed the title Fix grammar in threading.Barrier docs bpo 31191: Fix grammar in threading.Barrier docs Aug 12, 2017
@schedutron schedutron changed the title bpo 31191: Fix grammar in threading.Barrier docs bpo-31191: Fix grammar in threading.Barrier docs Aug 12, 2017
@JulienPalard
Copy link
Copy Markdown
Member

@schedutron Thanks for your contribution!

This paragraph, and the whole documentation, are line-wrapped at the 80th column, would you please wrap your modification at the 80th too?

c.f.: https://devguide.python.org/documenting/?highlight=documentation#style-guide

@schedutron
Copy link
Copy Markdown
Contributor Author

I care about PEP8 while programming still I missed this text wrapping! Anyways, thanks @JulienPalard, I've implemented the wrapping now.

@JulienPalard
Copy link
Copy Markdown
Member

LGTM

@schedutron
Copy link
Copy Markdown
Contributor Author

I think I've signed the CLA, still the tag persists.

@JulienPalard
Copy link
Copy Markdown
Member

@schedutron yes, removing the tag is not automatic, see: python/the-knights-who-say-ni#110

@schedutron
Copy link
Copy Markdown
Contributor Author

schedutron commented Aug 14, 2017

@the-knights-who-say-ni I've signed the CLA.

@Mariatta
Copy link
Copy Markdown
Member

Thanks for the reviews @rhettinger and @JulienPalard

@schedutron, You submitted the CLA two days ago, which was a weekend day in the US.
DevGuide explains that it can take one US business day to process the CLA. Thanks for the patience.

@Mariatta Mariatta merged commit 143be36 into python:master Aug 14, 2017
@Mariatta
Copy link
Copy Markdown
Member

Thanks @schedutron and congrats on your first contribution to CPython 🌮

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Aug 27, 2017
@bedevere-bot
Copy link
Copy Markdown

GH-3224 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Aug 27, 2017
Mariatta added a commit that referenced this pull request Aug 27, 2017
@schedutron schedutron changed the title bpo-31191: Fix grammar in threading.Barrier docs bpo-31191: Fix grammar in threading.Barrier docs Aug 29, 2017
@schedutron schedutron changed the title bpo-31191: Fix grammar in threading.Barrier docs bpo-31191: Fix grammar in threading.Barrier docs Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants