bpo-31191: Fix grammar in threading.Barrier docs#3080
bpo-31191: Fix grammar in threading.Barrier docs#3080Mariatta merged 2 commits intopython:masterfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@schedutron Thanks for your contribution! This paragraph, and the whole documentation, are line-wrapped at the 80th column, would you please wrap your modification at the 80th too? c.f.: https://devguide.python.org/documenting/?highlight=documentation#style-guide |
|
I care about PEP8 while programming still I missed this text wrapping! Anyways, thanks @JulienPalard, I've implemented the wrapping now. |
|
LGTM |
|
I think I've signed the CLA, still the tag persists. |
|
@schedutron yes, removing the tag is not automatic, see: python/the-knights-who-say-ni#110 |
|
@the-knights-who-say-ni I've signed the CLA. |
|
Thanks for the reviews @rhettinger and @JulienPalard @schedutron, You submitted the CLA two days ago, which was a weekend day in the US. |
|
Thanks @schedutron and congrats on your first contribution to CPython 🌮 |
|
GH-3224 is a backport of this pull request to the 3.6 branch. |
threading.Barrier docs
threading.Barrier docs
https://bugs.python.org/issue31191