bpo-46246: add missing __slots__ to importlib.metadata.DeprecatedList#30452
Merged
miss-islington merged 4 commits intopython:mainfrom Feb 11, 2022
Merged
bpo-46246: add missing __slots__ to importlib.metadata.DeprecatedList#30452miss-islington merged 4 commits intopython:mainfrom
miss-islington merged 4 commits intopython:mainfrom
Conversation
AlexWaygood
reviewed
Jan 7, 2022
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Jan 7, 2022
sobolevn
reviewed
Jan 7, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Is there a way to automate this check? What do you think?
Contributor
Author
|
@sobolevn it might indeed be worthwhile to add a test that walks the whole stdlib for these kind of simple It'd be out of scope of this PR so I'll float the idea on bugs.python.org edit: link to said ticket: https://bugs.python.org/issue46298 |
kumaraditya303
approved these changes
Jan 11, 2022
|
This PR is stale because it has been open for 30 days with no activity. |
jaraco
reviewed
Feb 11, 2022
…nd remove deprecated usage.
jaraco
approved these changes
Feb 11, 2022
Member
|
I've backported the change to importlib_metadata and published as v4.11.0. Thanks for the contrib. |
Contributor
|
@ariebovenberg: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @ariebovenberg for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 11, 2022
…pythonGH-30452) Confirmed with @jaraco that this indeed needs a fix. A question that came up while I was digging into the code: I think `SelectableGroups` could similarly use `__slots__ = ()`, since its purpose seems only for convenience around `dict`, not to have attributes of its own. Automerge-Triggered-By: GH:jaraco (cherry picked from commit dd76b3f) Co-authored-by: Arie Bovenberg <a.c.bovenberg@gmail.com>
|
GH-31269 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 11, 2022
…GH-30452) Confirmed with @jaraco that this indeed needs a fix. A question that came up while I was digging into the code: I think `SelectableGroups` could similarly use `__slots__ = ()`, since its purpose seems only for convenience around `dict`, not to have attributes of its own. Automerge-Triggered-By: GH:jaraco (cherry picked from commit dd76b3f) Co-authored-by: Arie Bovenberg <a.c.bovenberg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed with @jaraco that this indeed needs a fix.
A question that came up while I was digging into the code: I think
SelectableGroupscould similarly use__slots__ = (), since its purpose seems only for convenience arounddict, not to have attributes of its own.https://bugs.python.org/issue46246
Automerge-Triggered-By: GH:jaraco