Upload NEWS file as artifact#30419
Conversation
|
Conflict resolved! Would be nice to get this merged, it'd make reviewing docs PRs much easier: can download the generated files rather than checking out the branch locally and building them manually. |
|
Conflict resolved! |
|
(I'm working my way through some PRs which have been approved and are labeled "awaiting merge", hence my seemingly bolt from the blue comment. Why? Read here.) Can this be merged or are you still waiting for @Mariatta and @ezio-melotti to review? |
ezio-melotti
left a comment
ezio-melotti
left a comment
There was a problem hiding this comment.
Do we know how much storage is the python org using?
I don't expect the NEWS file to be particularly large, but if it gets generated for each PR it will add up and we might eventually reach the limit. We can also tweak the number of day the artifact is stored before being automatically deleted.
Other than that, the PR LGTM.
|
The current usage will be visible under https://github.com/organizations/python/settings/billing for org admins. |
|
Also the NEWS file is only 2% the size of the docs artifact we've been uploading for a long time and apparently that's not been a problem.
|
ezio-melotti
left a comment
ezio-melotti
left a comment
There was a problem hiding this comment.
In that case I guess it's not a problem. FWIW the artifact retention period is currently set at 90 days. We can lower it if space becomes a problem.
9 participants
Fixes python/core-workflow#147.
Since that issue was opened, we've moved testing from Travis CI to GitHub Actions.
And more recently the blurb tool is now being as part of
make buildcalled as part ofmake ... doctestin the "Check documentation" step (#30009).So let's also upload the generated
NEWSfile as an artifact so it can be inspected after the build.For example, it's available to download here: